mikhail
8e0ab374af
Веха 2D-ЧЕРТЁЖ, инкремент 3. DrawingService.AddLinearDimensionAsync: (ISymbols2D Container)view (QI) → LineDimensions.Add → X1..Y3 (локальная СК вида) + Orientation + AutoNominalValue → Update → проверка Valid → ((IDimensionText)dim).NominalValue. Свой enum DimensionOrientation (horizontal/vertical/parallel). Новый инструмент drawing_add_linear_dimension. DrawingViewsResult += ViewNumbers (адресация видов). Находка: размеры НЕ в IView.ObjectCount (он про геометрию IDrawingContainer) — проверка попадания в вид через ISymbols2DContainer.LineDimensions.Count. Ревью Codex спека учтено: RequireDistinctPoints (нулевая длина) + Valid после Update; контракт «первый несистемный вид»; null-check Add; AutoNominalValue явно; ViewNumbers required + текст ответа create_standard_views; тесты адресации/негатив. Тесты: +8 unit (DimensionOrientations, DrawingValidation), +5 integration (DrawingDimensionTests). Итого 131 unit + 70 integration = 201. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
72 lines
2.6 KiB
C#
72 lines
2.6 KiB
C#
using Kompas.Mcp.Core.Drawings;
|
|
|
|
namespace Kompas.Mcp.Tests;
|
|
|
|
[Trait("Category", "Unit")]
|
|
public sealed class DrawingValidationTests
|
|
{
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
[InlineData(" ")]
|
|
public void NormalizeModelPath_throws_on_empty(string? path)
|
|
=> Assert.Throws<ArgumentException>(() => DrawingValidation.NormalizeModelPath(path));
|
|
|
|
[Theory]
|
|
[InlineData(@"C:\m\part.step")]
|
|
[InlineData(@"C:\m\part.txt")]
|
|
[InlineData(@"C:\m\part")]
|
|
public void NormalizeModelPath_throws_on_wrong_extension(string path)
|
|
=> Assert.Throws<ArgumentException>(() => DrawingValidation.NormalizeModelPath(path));
|
|
|
|
[Theory]
|
|
[InlineData(@"C:\m\part.m3d", ".m3d")]
|
|
[InlineData(@"C:\m\frame.a3d", ".a3d")]
|
|
[InlineData(@" C:\m\part.M3D ", ".m3d")]
|
|
[InlineData(@"C:\модели\деталь.m3d", ".m3d")] // кириллица в пути
|
|
public void NormalizeModelPath_accepts_model_files(string path, string expectedExt)
|
|
{
|
|
var result = DrawingValidation.NormalizeModelPath(path);
|
|
Assert.True(Path.IsPathFullyQualified(result));
|
|
Assert.EndsWith(expectedExt, result, StringComparison.OrdinalIgnoreCase);
|
|
}
|
|
|
|
[Fact]
|
|
public void NormalizeModelPath_preserves_cyrillic()
|
|
{
|
|
var result = DrawingValidation.NormalizeModelPath(@"C:\модели\деталь.m3d");
|
|
Assert.Contains("деталь", result);
|
|
Assert.Contains("модели", result);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0)]
|
|
[InlineData(-1)]
|
|
[InlineData(double.NaN)]
|
|
[InlineData(double.PositiveInfinity)]
|
|
public void RequireScale_throws_on_non_positive_or_non_finite(double scale)
|
|
=> Assert.Throws<ArgumentOutOfRangeException>(() => DrawingValidation.RequireScale(scale));
|
|
|
|
[Theory]
|
|
[InlineData(1.0)]
|
|
[InlineData(0.5)]
|
|
[InlineData(2.0)]
|
|
public void RequireScale_accepts_positive(double scale)
|
|
=> Assert.Null(Record.Exception(() => DrawingValidation.RequireScale(scale)));
|
|
|
|
[Fact]
|
|
public void RequireFiniteCoords_throws_on_non_finite()
|
|
{
|
|
Assert.Throws<ArgumentException>(() => DrawingValidation.RequireFiniteCoords(0, double.NaN));
|
|
Assert.Throws<ArgumentException>(() => DrawingValidation.RequireFiniteCoords(double.PositiveInfinity));
|
|
Assert.Null(Record.Exception(() => DrawingValidation.RequireFiniteCoords(0, 1, -5, 40)));
|
|
}
|
|
|
|
[Fact]
|
|
public void RequireDistinctPoints_throws_on_coincident()
|
|
{
|
|
Assert.Throws<ArgumentException>(() => DrawingValidation.RequireDistinctPoints(10, 20, 10, 20));
|
|
Assert.Null(Record.Exception(() => DrawingValidation.RequireDistinctPoints(0, 0, 40, 0)));
|
|
}
|
|
}
|